Issue 8573023: NaCl: Re-enable run_inbrowser_crash_in_syscall_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8573023: NaCl: Re-enable run_inbrowser_crash_in_syscall_test (Closed)

Created:
9 years, 1 month ago by Mark Seaborn

Modified:
9 years, 1 month ago

Reviewers:
Nick Bray, Nick Bray (chromium)

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Re-enable run_inbrowser_crash_in_syscall_test The in-browser crash tests used to be flaky, but this was fixed some time ago. More recently, the inbrowser_crash_in_syscall test got broken by a change that caused the Breakpad handler to get run twice per crash, but this has now been fixed too. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2173 TEST=nacl_integration Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110470

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	chrome/test/nacl_test_injection/buildbot_nacl_integration.py	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

This depends on a DEPS update which I'll commit first.

9 years, 1 month ago (2011-11-15 23:16:38 UTC) #1

LGTM

Expand Messages | Collapse Messages