Issue 8573021: chrome: Remove 14 exit time destructors and 2 static initializers.

Issue 8573021: chrome: Remove 14 exit time destructors and 2 static initializers. (Closed)

Created:
9 years, 1 month ago by Nico

Modified:
9 years, 1 month ago

Reviewers:
Mark Mentovai, joth, Mattias Nissler (ping if slow)

CC:
chromium-reviews, James Su, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome: Remove 14 exit time destructors and 2 static initializers. BUG=101600, 94925 TEST=none TBR=mnissler Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110235 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110330

Patch Set 3 : Hopefully fix problems seen on the bots #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -59 lines)			Patch
M	chrome/browser/autocomplete/builtin_provider.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/character_encoding.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/content_settings/tab_specific_content_settings.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google/google_update_settings_posix.cc	View		4 chunks	+12 lines, -7 lines	1 comment	Download
M	chrome/browser/metrics/thread_watcher.h	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/metrics/thread_watcher.cc	View	1	5 chunks	+21 lines, -16 lines	0 comments	Download
M	chrome/browser/policy/device_management_backend_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc	View	1	1 chunk	+4 lines, -8 lines	0 comments	Download
M	chrome/browser/search_engines/search_terms_data.cc	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/about_chrome_dialog.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/web_resource/gpu_blacklist_updater.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM, to both the code and the grammatical improvements.

9 years, 1 month ago (2011-11-15 23:37:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8573021/2001

9 years, 1 month ago (2011-11-15 23:44:03 UTC) #3

commit-bot: I haz the power

Presubmit check for 8573021-2001 failed and returned exit status 1. Running presubmit commit checks ...

9 years, 1 month ago (2011-11-15 23:44:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8573021/2001

9 years, 1 month ago (2011-11-15 23:46:23 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8573021/7001

9 years, 1 month ago (2011-11-16 17:25:30 UTC) #9

joth

after the fact drive-by. great work removing all these static initializers...! http://codereview.chromium.org/8573021/diff/7001/chrome/browser/google/google_update_settings_posix.cc File chrome/browser/google/google_update_settings_posix.cc (right): ...

9 years, 1 month ago (2011-11-18 01:16:36 UTC) #11

Mark Mentovai

9 years, 1 month ago (2011-11-18 01:53:23 UTC) #12

Nico’s adopted this pattern intentionally. I think it’s fine.

Expand Messages | Collapse Messages