chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc - Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Don't call Run() on null callbacks. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc b/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

index 41c7d6f57b61156be17277653cc582189c49695a..b68c8822862892de50568224159df7e940e4da82 100644

--- a/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

+++ b/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

@@ -83,7 +83,8 @@ class PhishingTermFeatureExtractorTest : public ::testing::Test {

extractor_->ExtractFeatures(

page_text,

features,

- NewCallback(this, &PhishingTermFeatureExtractorTest::ExtractionDone));

+ base::Bind(&PhishingTermFeatureExtractorTest::ExtractionDone,

+ base::Unretained(this)));

msg_loop_.Run();

return success_;

}

@@ -92,7 +93,8 @@ class PhishingTermFeatureExtractorTest : public ::testing::Test {

extractor_->ExtractFeatures(

page_text,

features,

- NewCallback(this, &PhishingTermFeatureExtractorTest::ExtractionDone));

+ base::Bind(&PhishingTermFeatureExtractorTest::ExtractionDone,

+ base::Unretained(this)));

msg_loop_.PostTask(

FROM_HERE,

base::Bind(&PhishingTermFeatureExtractorTest::QuitExtraction,

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc ('k') | no next file » | no next file with comments »