chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc - Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Don't call Run() on null callbacks. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc ('k') | chrome/renderer/safe_browsing/phishing_term_feature_extractor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

index d66d54ba85faad1dacd0537492009d9163573844..6cea74d34e634bd9ab70307c8dafe37fd225cc10 100644

--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

@@ -64,7 +64,8 @@ class PhishingDOMFeatureExtractorTest : public RenderViewFakeResourcesTest {

success_ = false;

extractor_->ExtractFeatures(

features,

- NewCallback(this, &PhishingDOMFeatureExtractorTest::ExtractionDone));

+ base::Bind(&PhishingDOMFeatureExtractorTest::ExtractionDone,

+ base::Unretained(this)));

message_loop_.Run();

return success_;

}