chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Don't call Run() on null callbacks. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index e9f3da73dbfcccafe6c823b58c836ec991eb4714..2aa75964d8291730c9de048186cde460ef3af18f 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -6,6 +6,7 @@

#include <queue>

#include <string>

+#include "base/bind.h"

#include "base/callback.h"

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

@@ -86,7 +87,8 @@ class ClientSideDetectionServiceTest : public testing::Test {

request->set_is_phishing(true); // client thinks the URL is phishing.

csd_service_->SendClientReportPhishingRequest(

request,

- NewCallback(this, &ClientSideDetectionServiceTest::SendRequestDone));

+ base::Bind(&ClientSideDetectionServiceTest::SendRequestDone,

+ base::Unretained(this)));

phishing_url_ = phishing_url;

msg_loop_.Run(); // Waits until callback is called.

return is_phishing_;