chrome/browser/safe_browsing/client_side_detection_host.h - Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.h

Issue 8573018: Convert to base::Callback in safe_browsing client-side-detection code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Don't call Run() on null callbacks. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc ('k') | chrome/browser/safe_browsing/client_side_detection_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host.h

diff --git a/chrome/browser/safe_browsing/client_side_detection_host.h b/chrome/browser/safe_browsing/client_side_detection_host.h

index a45a986f3980434bf8d95ec6c4da07cfb985bfb3..727852f7d015ed5c87e0644060944819a46df89f 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host.h

+++ b/chrome/browser/safe_browsing/client_side_detection_host.h

@@ -121,7 +121,7 @@ class ClientSideDetectionHost : public TabContentsObserver,

// Handles registering notifications with the NotificationService.

content::NotificationRegistrar registrar_;

- base::ScopedCallbackFactory<ClientSideDetectionHost> cb_factory_;

+ base::WeakPtrFactory<ClientSideDetectionHost> weak_factory_;

// Unique page ID of the most recent unsafe site that was loaded in this tab

// as well as the UnsafeResource.