Issue 8573012: Unify views implementation of FindBarHost::GetWidgetPositionNative

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8573012: Unify views implementation of FindBarHost::GetWidgetPositionNative (Closed)

Created:
9 years, 1 month ago by sadrul

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Unify views implementation of FindBarHost::GetWidgetPositionNative BUG=104374 TEST=FindInPageControllerTest.FindMovesWhenObscuring on windows, linux_chromeos and aura bots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110200

Patch Set 1 : . #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -30 lines)			Patch
M	chrome/browser/ui/views/find_bar_host.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_host_aura.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_host_gtk.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_host_win.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

The bots are happy: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/3199 http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/995 (the trybot for linux_aura doesn't do browser_tests)

9 years, 1 month ago (2011-11-15 21:19:37 UTC) #2

lgtm

Expand Messages | Collapse Messages