Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3509)

Unified Diff: chrome/browser/sync/syncable/syncable.cc

Issue 8573011: Event tracing for sync events (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix line length issues Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/syncable/syncable.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/syncable/syncable.cc
diff --git a/chrome/browser/sync/syncable/syncable.cc b/chrome/browser/sync/syncable/syncable.cc
index b1548f0d8d4611b01650e277d4a5599526033238..8b383a7ab0cde2a55bc15b936120feadd0ce6cb8 100644
--- a/chrome/browser/sync/syncable/syncable.cc
+++ b/chrome/browser/sync/syncable/syncable.cc
@@ -13,6 +13,7 @@
#include <set>
#include <string>
+#include "base/debug/trace_event.h"
#include "base/compiler_specific.h"
#include "base/file_util.h"
#include "base/hash_tables.h"
@@ -1133,23 +1134,15 @@ ScopedKernelLock::ScopedKernelLock(const Directory* dir)
// Transactions
void BaseTransaction::Lock() {
- base::TimeTicks start_time = base::TimeTicks::Now();
+ TRACE_EVENT2("sync_lock_contention", "AcquireLock",
+ "src_file", from_here_.file_name(),
+ "src_func", from_here_.function_name());
dirkernel_->transaction_mutex.Acquire();
-
- time_acquired_ = base::TimeTicks::Now();
- const base::TimeDelta elapsed = time_acquired_ - start_time;
- VLOG_LOC(from_here_, 2)
- << name_ << " transaction waited "
- << elapsed.InSecondsF() << " seconds.";
}
void BaseTransaction::Unlock() {
dirkernel_->transaction_mutex.Release();
- const base::TimeDelta elapsed = base::TimeTicks::Now() - time_acquired_;
- VLOG_LOC(from_here_, 2)
- << name_ << " transaction completed in " << elapsed.InSecondsF()
- << " seconds.";
}
BaseTransaction::BaseTransaction(const tracked_objects::Location& from_here,
@@ -1158,6 +1151,9 @@ BaseTransaction::BaseTransaction(const tracked_objects::Location& from_here,
Directory* directory)
: from_here_(from_here), name_(name), writer_(writer),
directory_(directory), dirkernel_(directory->kernel_) {
+ TRACE_EVENT_BEGIN2("sync", name_,
+ "src_file", from_here_.file_name(),
+ "src_func", from_here_.function_name());
dirkernel_->transaction_observer.Call(FROM_HERE,
&TransactionObserver::OnTransactionStart, from_here_, writer_);
}
@@ -1167,17 +1163,19 @@ BaseTransaction::~BaseTransaction() {
dirkernel_->transaction_observer.Call(FROM_HERE,
&TransactionObserver::OnTransactionEnd, from_here_, writer_);
}
+ TRACE_EVENT_END0("sync", name_);
}
ReadTransaction::ReadTransaction(const tracked_objects::Location& location,
Directory* directory)
- : BaseTransaction(location, "Read", INVALID, directory) {
+ : BaseTransaction(location, "ReadTransaction", INVALID, directory) {
Lock();
}
ReadTransaction::ReadTransaction(const tracked_objects::Location& location,
const ScopedDirLookup& scoped_dir)
- : BaseTransaction(location, "Read", INVALID, scoped_dir.operator->()) {
+ : BaseTransaction(location, "ReadTransaction",
+ INVALID, scoped_dir.operator->()) {
Lock();
}
@@ -1187,14 +1185,15 @@ ReadTransaction::~ReadTransaction() {
WriteTransaction::WriteTransaction(const tracked_objects::Location& location,
WriterTag writer, Directory* directory)
- : BaseTransaction(location, "Write", writer, directory) {
+ : BaseTransaction(location, "WriteTransaction", writer, directory) {
Lock();
}
WriteTransaction::WriteTransaction(const tracked_objects::Location& location,
WriterTag writer,
const ScopedDirLookup& scoped_dir)
- : BaseTransaction(location, "Write", writer, scoped_dir.operator->()) {
+ : BaseTransaction(location, "WriteTransaction",
+ writer, scoped_dir.operator->()) {
Lock();
}
« no previous file with comments | « chrome/browser/sync/syncable/syncable.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698