Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/browser/resources/profiler.js

Issue 8572042: Make the "source location" links on about:profiler open in a new tab by default, since that is us... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var g_browserBridge; 5 var g_browserBridge;
6 var g_mainView; 6 var g_mainView;
7 7
8 // TODO(eroman): Don't repeat the work of grouping, sorting, merging on every 8 // TODO(eroman): Don't repeat the work of grouping, sorting, merging on every
9 // redraw. Rather do it only once when one of its dependencies 9 // redraw. Rather do it only once when one of its dependencies
10 // change and cache the result. 10 // change and cache the result.
(...skipping 1015 matching lines...) Expand 10 before | Expand all | Expand 10 after
1026 var filename = getFilenameFromPath(filepath); 1026 var filename = getFilenameFromPath(filepath);
1027 var linenumber = m[2]; 1027 var linenumber = m[2];
1028 1028
1029 var link = addNode(td, 'a', filename + ' [' + linenumber + ']'); 1029 var link = addNode(td, 'a', filename + ' [' + linenumber + ']');
1030 // http://chromesrc.appspot.com is a server I wrote specifically for 1030 // http://chromesrc.appspot.com is a server I wrote specifically for
1031 // this task. It redirects to the appropriate source file; the file 1031 // this task. It redirects to the appropriate source file; the file
1032 // paths given by the compiler can be pretty crazy and different 1032 // paths given by the compiler can be pretty crazy and different
1033 // between platforms. 1033 // between platforms.
1034 link.href = 'http://chromesrc.appspot.com/?path=' + 1034 link.href = 'http://chromesrc.appspot.com/?path=' +
1035 encodeURIComponent(filepath) + '&line=' + linenumber; 1035 encodeURIComponent(filepath) + '&line=' + linenumber;
1036 link.target = '_blank';
1036 return; 1037 return;
1037 } 1038 }
1038 } 1039 }
1039 1040
1040 // String values can get pretty long. If the string contains no spaces, then 1041 // String values can get pretty long. If the string contains no spaces, then
1041 // CSS fails to wrap it, and it overflows the cell causing the table to get 1042 // CSS fails to wrap it, and it overflows the cell causing the table to get
1042 // really big. We solve this using a hack: insert a <wbr> element after 1043 // really big. We solve this using a hack: insert a <wbr> element after
1043 // every single character. This will allow the rendering engine to wrap the 1044 // every single character. This will allow the rendering engine to wrap the
1044 // value, and hence avoid it overflowing! 1045 // value, and hence avoid it overflowing!
1045 var kMinLengthBeforeWrap = 20; 1046 var kMinLengthBeforeWrap = 20;
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
1551 groupKey.push(entry); 1552 groupKey.push(entry);
1552 } 1553 }
1553 1554
1554 return JSON.stringify(groupKey); 1555 return JSON.stringify(groupKey);
1555 }; 1556 };
1556 }, 1557 },
1557 }; 1558 };
1558 1559
1559 return MainView; 1560 return MainView;
1560 })(); 1561 })();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698