chrome/browser/safe_browsing/download_protection_service.cc - Issue 8572037: Whitelist executables that are trusted in the SafeBrowsing download protection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 8572037: Whitelist executables that are trusted in the SafeBrowsing download protection. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.h ('k') | chrome/browser/safe_browsing/download_protection_service_unittest.cc » ('j') | chrome/browser/safe_browsing/download_protection_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc

index 897d401e144041be6c7026cf2fdc1c6e860988b6..e6eb57f04df7f4661f5b0fabe4419621fd842c71 100644

--- a/chrome/browser/safe_browsing/download_protection_service.cc

+++ b/chrome/browser/safe_browsing/download_protection_service.cc

@@ -484,11 +484,15 @@ class DownloadProtectionService::CheckClientDownloadRequest

sb_service_->MatchDownloadWhitelistUrl(info_.referrer_url)) {

reason = REASON_WHITELISTED_REFERRER;

}

- if (reason != REASON_MAX ||

- signature_info_.certificate_chain_size() > 0) {

+ if (reason != REASON_MAX || signature_info_.trusted()) {

UMA_HISTOGRAM_COUNTS("SBClientDownload.SignedOrWhitelistedDownload", 1);

}

+ if (reason == REASON_MAX && signature_info_.trusted()) {

+ // TODO(noelutz): implement a certificate whitelist and only whitelist

+ // binaries whose certificate match the whitelist.

+ reason = REASON_TRUSTED_EXECUTABLE;

+ }

if (reason != REASON_MAX) {

RecordImprovedProtectionStats(reason);

CheckDigestList();