Whitelist executables that are trusted in the SafeBrowsing download protection.

Whitelist executables that are trusted in the SafeBrowsing download protection.

Eventually, we will have a certificate whitelist. In this first version we
consider trusted binaries as safe.

BUG=102540
TEST=No visible change. Run all tests in DownloadProtectionServiceTest.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110251

[mattm, 2011-11-16 01:38:01]

http://codereview.chromium.org/8572037/diff/1/chrome/browser/safe_browsing/do...
File chrome/browser/safe_browsing/download_protection_service.cc (right):

http://codereview.chromium.org/8572037/diff/1/chrome/browser/safe_browsing/do...
chrome/browser/safe_browsing/download_protection_service.cc:503: //
TODO(noelutz): check signature and CA against whitelist.
the new todo seems to overlap with this one

http://codereview.chromium.org/8572037/diff/1/chrome/browser/safe_browsing/do...
File chrome/browser/safe_browsing/download_protection_service_unittest.cc
(right):

http://codereview.chromium.org/8572037/diff/1/chrome/browser/safe_browsing/do...
chrome/browser/safe_browsing/download_protection_service_unittest.cc:558:
EXPECT_EQ(DownloadProtectionService::SAFE, result_);
add VerifyAndClearExpectations call

[noelutz, 2011-11-16 01:57:18]

thanks. please take another look.

noe.

http://codereview.chromium.org/8572037/diff/1/chrome/browser/safe_browsing/do...
File chrome/browser/safe_browsing/download_protection_service.cc (right):

http://codereview.chromium.org/8572037/diff/1/chrome/browser/safe_browsing/do...
chrome/browser/safe_browsing/download_protection_service.cc:503: //
TODO(noelutz): check signature and CA against whitelist.
On 2011/11/16 01:38:01, mattm wrote:
> the new todo seems to overlap with this one

Done.

http://codereview.chromium.org/8572037/diff/1/chrome/browser/safe_browsing/do...
File chrome/browser/safe_browsing/download_protection_service_unittest.cc
(right):

http://codereview.chromium.org/8572037/diff/1/chrome/browser/safe_browsing/do...
chrome/browser/safe_browsing/download_protection_service_unittest.cc:558:
EXPECT_EQ(DownloadProtectionService::SAFE, result_);
On 2011/11/16 01:38:01, mattm wrote:
> add VerifyAndClearExpectations call

Done.

[mattm, 2011-11-16 02:00:48]

lgtm

[commit-bot: I haz the power, 2011-11-16 02:01:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noelutz@google.com/8572037/3002

[commit-bot: I haz the power, 2011-11-16 04:30:54]

Change committed as 110251