CUPS: Add a regression test for duplex detection.

CUPS: Add a regression test for duplex detection.

BUG=103999
TEST=included
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110433

[kmadhusu, 2011-11-16 20:43:29]

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
File chrome/browser/printing/print_system_task_proxy.h (right):

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
chrome/browser/printing/print_system_task_proxy.h:64: PrintSystemTaskProxy();
if defined(UNIT_TEST) && defined(USE_CUPS) 

PrintSystemTaskProxy();

#endif

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
File chrome/browser/printing/print_system_task_proxy_unittest.cc (right):

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
chrome/browser/printing/print_system_task_proxy_unittest.cc:226:
TEST(PrintSystemTaskProxyTest, DetectDuplexModeCUPS) {
Can you add another test for windows duplex setting?

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
chrome/browser/printing/print_system_task_proxy_unittest.cc:242: 
nit: remove blank line

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
chrome/browser/printing/print_system_task_proxy_unittest.cc:261:
EXPECT_EQ(printing::SIMPLEX, default_duplex_setting_value);
Can you add another test to verify that a ppd without duplex setting info will
return UNKNOWN_DUPLEX_MODE?

[Lei Zhang, 2011-11-17 00:20:15]

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
File chrome/browser/printing/print_system_task_proxy.h (right):

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
chrome/browser/printing/print_system_task_proxy.h:64: PrintSystemTaskProxy();
On 2011/11/16 20:43:29, kmadhusu wrote:
> if defined(UNIT_TEST) && defined(USE_CUPS) 
> 
> PrintSystemTaskProxy();
> 
> #endif

Done.

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
File chrome/browser/printing/print_system_task_proxy_unittest.cc (right):

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
chrome/browser/printing/print_system_task_proxy_unittest.cc:226:
TEST(PrintSystemTaskProxyTest, DetectDuplexModeCUPS) {
On 2011/11/16 20:43:29, kmadhusu wrote:
> Can you add another test for windows duplex setting?

That's beyond the scope of this CL.

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
chrome/browser/printing/print_system_task_proxy_unittest.cc:242: 
On 2011/11/16 20:43:29, kmadhusu wrote:
> nit: remove blank line

Done.

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
chrome/browser/printing/print_system_task_proxy_unittest.cc:261:
EXPECT_EQ(printing::SIMPLEX, default_duplex_setting_value);
On 2011/11/16 20:43:29, kmadhusu wrote:
> Can you add another test to verify that a ppd without duplex setting info will
> return UNKNOWN_DUPLEX_MODE?

Done.

[kmadhusu, 2011-11-17 01:03:00]

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
File chrome/browser/printing/print_system_task_proxy_unittest.cc (right):

http://codereview.chromium.org/8572036/diff/7/chrome/browser/printing/print_s...
chrome/browser/printing/print_system_task_proxy_unittest.cc:226:
TEST(PrintSystemTaskProxyTest, DetectDuplexModeCUPS) {
On 2011/11/17 00:20:16, Lei Zhang wrote:
> On 2011/11/16 20:43:29, kmadhusu wrote:
> > Can you add another test for windows duplex setting?
> 
> That's beyond the scope of this CL.

From my understanding, the purpose of this CL to add tests to verify/test duplex
settings irrespective of the platform.   Since you are adding new tests, I
thought it is better to add test for windows duplex setting.

[kmadhusu, 2011-11-17 01:09:13]

lgtm

As we discussed, add the windows test in a separate cl.