Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 8572030: wayland: forward declare WaylandEvent (Closed)

Created:
9 years, 1 month ago by Mandeep Singh Baines
Modified:
9 years, 1 month ago
CC:
chromium-reviews, brettw-cc_chromium.org, Emmanuel Saint-loubert-BiƩ, recbradford, Elliot Glaysher
Visibility:
Public.

Description

wayland: forward declare WaylandEvent Don't pollute the namespace with defines from C header files and forward declare WaylandEvent. BUG=102903 TEST=compiles Change-Id: I5cd50c04361d4d053bdf8c193071a4c7808c51d7 R=oshima@chromium.org,dnicoara@chromium.org,mark@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M base/event_types.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mandeep Singh Baines
9 years, 1 month ago (2011-11-15 22:20:34 UTC) #1
Mark Mentovai
LGTM
9 years, 1 month ago (2011-11-15 22:22:12 UTC) #2
oshima
LGTM
9 years, 1 month ago (2011-11-15 22:23:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msb@chromium.org/8572030/1
9 years, 1 month ago (2011-11-15 22:40:00 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 23:54:43 UTC) #5
Change committed as 110211

Powered by Google App Engine
This is Rietveld 408576698