Issue 8572022: aura: Fix BrowserInitTest.OpenAppShortcutPanel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8572022: aura: Fix BrowserInitTest.OpenAppShortcutPanel. (Closed)

Created:
9 years, 1 month ago by sadrul

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Remove the experiment to always open app in windows. BUG=103483, 104413 TEST=BrowserInitTest.OpenAppShortcutPanel, PanelAppBrowserTest.OpenAppInPanel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110249

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	chrome/browser/ui/browser.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

http://codereview.chromium.org/8572022/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/8572022/diff/1/chrome/browser/ui/browser.cc#newcode613 chrome/browser/ui/browser.cc:613: #if defined(USE_AURA) I actually think we should remove this. ...

9 years, 1 month ago (2011-11-15 23:27:28 UTC) #2

lgtm

Expand Messages | Collapse Messages