chromeos: Implement the new D-Bus client for update engine.

chromeos: Implement the new D-Bus client for update engine.

This is part 1 of the UpdateLibrary to UpdateEngineClient migration.
The new files are added but not used from Chrome yet.

The new code is based on update_library.cc and chromeos_update_engine.cc,
and the new code will replace the them.

For code review, please refer to the files below:

http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/cros/update_library.h?view=markup
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/cros/update_library.cc?view=markup
http://git.chromium.org/gitweb/?p=chromiumos/platform/cros.git;a=blob;f=chromeos_update_engine.h;hb=HEAD
http://git.chromium.org/gitweb/?p=chromiumos/platform/cros.git;a=blob;f=chromeos_update_engine.cc;hb=HEAD

BUG=chromium-os:16564
TEST=chrome and tests build.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110467

[stevenjb, 2011-11-16 01:14:29]

This lgtm with nits, but you should probably find someone more familiar with the
update engine code to take a look.

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
File chrome/browser/chromeos/dbus/update_engine_client.cc (right):

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.cc:61: // brightness level in
Chrome as it'll make things less reliable.
nit: never use it'll, it just sounds wrong, use "it will"

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
File chrome/browser/chromeos/dbus/update_engine_client.h (right):

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.h:86: // "beta-channel" and
"dev-channel".
nit: s/and/or

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.h:93: // Requests to get the
release trackand calls |callback| with the
nit: "track and"

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.h:100: // Ideally, the D-Bus
client shoudl be state-less, but there are clients
nit: should

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.h:110: virtual
~UpdateEngineClient();
nit: should be first function, not last (further away from constructor, but
still easier to find / less unexpected)

[satorux1, 2011-11-17 02:58:05]

Thanks. The original author of update_library.cc and chromeos_update_engine.cc
left the project a while ago.  Hopefully, the patch is just mechanical
conversion from these files.

I talked to adlr and petkov about how to test update engine, and tested the code
carefully per their suggestions. In the next patch, we'll replace UpdateLibrary
with the UpdateEngineClient.

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
File chrome/browser/chromeos/dbus/update_engine_client.cc (right):

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.cc:61: // brightness level in
Chrome as it'll make things less reliable.
On 2011/11/16 01:14:29, Steven Bennetts wrote:
> nit: never use it'll, it just sounds wrong, use "it will"

Done.

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
File chrome/browser/chromeos/dbus/update_engine_client.h (right):

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.h:86: // "beta-channel" and
"dev-channel".
On 2011/11/16 01:14:29, Steven Bennetts wrote:
> nit: s/and/or

Done.

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.h:93: // Requests to get the
release trackand calls |callback| with the
On 2011/11/16 01:14:29, Steven Bennetts wrote:
> nit: "track and"

Done.

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.h:100: // Ideally, the D-Bus
client shoudl be state-less, but there are clients
On 2011/11/16 01:14:29, Steven Bennetts wrote:
> nit: should

Done.

http://codereview.chromium.org/8572020/diff/1/chrome/browser/chromeos/dbus/up...
chrome/browser/chromeos/dbus/update_engine_client.h:110: virtual
~UpdateEngineClient();
On 2011/11/16 01:14:29, Steven Bennetts wrote:
> nit: should be first function, not last (further away from constructor, but
> still easier to find / less unexpected)

Done.