Issue 8572010: DevTools: reattach to previous RVH when pending navigation is being canceled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8572010: DevTools: reattach to previous RVH when pending navigation is being canceled (Closed)

Created:
9 years, 1 month ago by yurys

Modified:
9 years, 1 month ago

Reviewers:
jam, pfeldman, loislo

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: reattach to previous RVH when pending navigation is being canceled. BUG=DevTools window may close when navigating to different bookmarked pages TEST=DevToolsManagerTest.ReattachOnCancelPendingNavigation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110267

Patch Set 1 #

Patch Set 2 : Added test #

Total comments: 1

Patch Set 3 : Added missing OVERRIDE #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -0 lines)			Patch
M	content/browser/debugger/devtools_manager.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/debugger/devtools_manager.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	content/browser/debugger/devtools_manager_unittest.cc	View	1 2	3 chunks	+40 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/render_view_host_manager.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pfeldman

http://codereview.chromium.org/8572010/diff/2001/content/browser/tab_contents/render_view_host_manager.cc File content/browser/tab_contents/render_view_host_manager.cc (right): http://codereview.chromium.org/8572010/diff/2001/content/browser/tab_contents/render_view_host_manager.cc#newcode752 content/browser/tab_contents/render_view_host_manager.cc:752: devtools_manager->OnCancelPendingNavigation(pending_render_view_host, Looks good to me. Please make sure jam@ ...

9 years, 1 month ago (2011-11-15 17:03:35 UTC) #2

lgtm

Expand Messages | Collapse Messages