Add policies to control the disk cache size.

chrome/browser/profiles/profile_impl.cc

Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index c6eb3f6193e556de6e5bac0df734ff6a0663c67f..54cce2720ec4fc155c6cc88c5800063fd788be20 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -198,6 +198,17 @@ void GetCacheParameters(ContextType type, FilePath* cache_path,
   } else if (*max_size < 0) {
     *max_size = 0;
   }
+#if !defined(OS_CHROMEOS)
+  // If a policy is controlling the cache size it should override any
+  // command line flags.
+  if (kNormalContext == type) {
+    if (prefs && prefs->IsManagedPreference(prefs::kDiskCacheSize))
+      *max_size = prefs->GetInteger(prefs::kDiskCacheSize);
+  } else {
+    if (prefs && prefs->IsManagedPreference(prefs::kMediaCacheSize))
+      *max_size = prefs->GetInteger(prefs::kMediaCacheSize);
+  }

[Joao da Silva, 2011/11/15 14:12:53]

I think this policy should be user policy. The caches are stored in the profile
dir, and these policies could be used on chromeos too. It's also easier to
change in the future (e.g. to allow the user to configure the cache sizes
through some UI).

How about these changes:

1. don't read the command line here (remove the block above), and do the
equivalent logic in CommandLinePrefStore instead (it might require introducing
an IntSwitchToPreferenceMapEntry type)

2. register the prefs in the user prefs, with default value 0; this way, the
command line flags will override the default through the CommandLinePrefStore

3. the policies will override those prefs, if set;

4. in this function, just read the pref value from the profile PrefService (it
has to be passed as an argument to this function). It will either be the default
(0), the value from CommandLinePrefStore, or the policy value; in any case, it's
the right value. Also, don't wrap this reading with !OS_CHROMEOS.

+#endif
 }
 
 FilePath GetCachePath(const FilePath& base) {