views/widget/native_widget_aura.cc - Issue 8571026: Fix fullscreen mode on aura

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/widget/native_widget_aura.cc

Issue 8571026: Fix fullscreen mode on aura (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update comment Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/widget/native_widget_aura.cc

diff --git a/views/widget/native_widget_aura.cc b/views/widget/native_widget_aura.cc

index ee23f426f26c5b6a1d6c38078c1d2759ddc09c7a..cfa5a6a8de8b7c2496cf8a3edbfb8e2030c0f798 100644

--- a/views/widget/native_widget_aura.cc

+++ b/views/widget/native_widget_aura.cc

@@ -350,7 +350,13 @@ void NativeWidgetAura::SetShape(gfx::NativeRegion region) {

}

void NativeWidgetAura::Close() {

- Hide();

+ // |window_| may already be deleted by parent window. This can happen

+ // when this widget is child widget or has transient parent

+ // and ownership is WIDGET_OWNS_NATIVE_WIDGET.

+ DCHECK(window_ ||

+ ownership_ == Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET);

+ if (window_)

+ Hide();

if (!close_widget_factory_.HasWeakPtrs()) {

MessageLoop::current()->PostTask(

« no previous file with comments | « chrome/test/base/in_process_browser_test.cc ('k') | no next file » | no next file with comments »