Fix fullscreen mode on aura

views/widget/native_widget_aura.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/native_widget_aura.h"
 
 #include "base/bind.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/desktop.h"
 #include "ui/aura/desktop_observer.h"
@@ skipping 356 matching lines @@
 void NativeWidgetAura::EnableClose(bool enable) {
   // http://crbug.com/102581
   NOTIMPLEMENTED();
 }
 
 void NativeWidgetAura::Show() {
   ShowWithWindowState(ui::SHOW_STATE_INACTIVE);
 }
 
 void NativeWidgetAura::Hide() {
-  window_->Hide();
+  // |window_| may already be deleted by parent window.
+  if (window_)

[Ben Goodger (Google), 2011/11/16 15:48:25]

This seems kind of random. What other functions in NWA might be called after
window_ is randomly deleted?

[oshima, 2011/11/16 16:51:47]

On second thought, I think I should move this to Close, like
if (window_)
 Hide();

This happens when a window that has either child or transient child (similar to
tab contents detach fix i did a copule of weeks ago) is closing. Deleting parent
window deletes child & transient child before deleting child views, and deleting
view may try to close the NWA whose window has already been deleted.
 Since this should happen only when we're closing the window, Close is probably 
better place. This should also be possible when ownership is
WIDGET_OWNS_NATIVE_WIDGET, so I can add DCHECK. Please let me know what you
think.

BTW. my understanding of why this problem doesn't happen on gtk is because gtk
widget is refcounted. Not sure how this works on windows though.

+    window_->Hide();
 }
 
 void NativeWidgetAura::ShowMaximizedWithBounds(
     const gfx::Rect& restored_bounds) {
   window_->SetBounds(restored_bounds);
   ShowWithWindowState(ui::SHOW_STATE_MAXIMIZED);
 }
 
 void NativeWidgetAura::ShowWithWindowState(ui::WindowShowState state) {
   if (state == ui::SHOW_STATE_MAXIMIZED ||
@@ skipping 334 matching lines @@
   NOTIMPLEMENTED();
 }
 
 // static
 bool NativeWidgetPrivate::IsMouseButtonDown() {
   return aura::Desktop::GetInstance()->IsMouseButtonDown();
 }
 
 }  // namespace internal
 }  // namespace views