Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 8571024: convert options and bug reporter to chromey checkboxes (Closed)

Created:
9 years, 1 month ago by Evan Stade
Modified:
9 years, 1 month ago
Reviewers:
csilv, Dan Beam
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

convert options and bug reporter to chromey checkboxes BUG=103688 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -85 lines) Patch
M chrome/browser/resources/bug_report.html View 5 chunks +26 lines, -18 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/options_page.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/shared/css/checkbox.css View 6 chunks +17 lines, -7 lines 0 comments Download
M chrome/browser/resources/shared/css/chrome_shared.css View 3 chunks +12 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
could you two test this on mac and windows? Specifically check the vertical spacing of ...
9 years, 1 month ago (2011-11-16 04:09:03 UTC) #1
csilv
LGTM Tested on Mac, looks fantastic!
9 years, 1 month ago (2011-11-16 20:49:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8571024/1
9 years, 1 month ago (2011-11-17 02:17:00 UTC) #3
Dan Beam
estade and I decided it'd be easier to try this on Canary than building on ...
9 years, 1 month ago (2011-11-17 02:20:56 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 06:48:44 UTC) #5
Change committed as 110462

Powered by Google App Engine
This is Rietveld 408576698