Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 8571022: [Sync Setup UI] Separate stepping the SyncSetupWizard from syncSetup page navigation. (Closed)

Created:
9 years, 1 month ago by binji
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Sync Setup UI] Separate stepping the SyncSetupWizard from syncSetup page navigation. BUG=102591 TEST=type chrome://settings/syncSetup. You should see a sync dialog, not the personal options page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114147

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M chrome/browser/ui/webui/options/options_sync_setup_handler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/options_sync_setup_handler.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo_handler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo_handler.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
binji
atwilson: review stevenjb: fyi (and chromeos test?) It seems that a wizard step is required ...
9 years, 1 month ago (2011-11-16 01:49:20 UTC) #1
binji
ping!
9 years, 1 month ago (2011-11-18 01:22:55 UTC) #2
stevenjb
I will want to test this on ChromeOS. It seems like it should be OK, ...
9 years, 1 month ago (2011-11-18 01:47:37 UTC) #3
Andrew T Wilson (Slow)
LGTM
9 years, 1 month ago (2011-11-24 01:06:56 UTC) #4
binji
Hi Steven, can I get a yea/nay for this? It is a release-block Beta for ...
9 years ago (2011-12-12 19:17:20 UTC) #5
stevenjb
Hey Ben, I am so sorry I forgot about this. Can you rebase it and ...
9 years ago (2011-12-12 20:15:21 UTC) #6
stevenjb
Tested on ChromeOS, LGTM!
9 years ago (2011-12-12 21:37:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/8571022/8001
9 years ago (2011-12-13 00:00:01 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-13 01:44:33 UTC) #9
Change committed as 114147

Powered by Google App Engine
This is Rietveld 408576698