Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 8571019: Fix linux ProcessSingleton invalid message handling infinite log spam. (Closed)

Created:
9 years, 1 month ago by mattm
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix linux ProcessSingleton invalid message handling infinite log spam. Also fix a possible data race issue. Also convert NewRunnableMethod to base::Bind. BUG=103901, 87747 TEST=run chrome, then "echo hi | nc -U /tmp/.org.chromium.Chromium.FOO/SingletonSocket" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110408

Patch Set 1 : . #

Patch Set 2 : re-add FinishWithACK comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -12 lines) Patch
M chrome/browser/process_singleton_linux.cc View 1 14 chunks +29 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mattm
9 years, 1 month ago (2011-11-16 03:56:48 UTC) #1
mattm
On 2011/11/16 03:56:48, mattm wrote: (I think the data race may be crbug.com/87747. Gonna try ...
9 years, 1 month ago (2011-11-16 04:02:43 UTC) #2
willchan no longer on Chromium
lgtm
9 years, 1 month ago (2011-11-16 14:54:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/8571019/3002
9 years, 1 month ago (2011-11-16 22:43:09 UTC) #4
commit-bot: I haz the power
Try job failure for 8571019-3002 (retry) on linux_rel for step "unit_tests". It's a second try, ...
9 years, 1 month ago (2011-11-16 23:42:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/8571019/3002
9 years, 1 month ago (2011-11-16 23:49:22 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 00:53:05 UTC) #7
Change committed as 110408

Powered by Google App Engine
This is Rietveld 408576698