Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: chrome/app/breakpad_win.cc

Issue 8571010: Re-enable useful dumps on dev and beta channels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/breakpad_win.cc
===================================================================
--- chrome/app/breakpad_win.cc (revision 110070)
+++ chrome/app/breakpad_win.cc (working copy)
@@ -679,9 +679,12 @@
if (command.HasSwitch(switches::kFullMemoryCrashReport)) {
dump_type = kFullDumpType;
} else {
+ std::wstring channel_name(
+ GoogleUpdateSettings::GetChromeChannel(!is_per_user_install));
+
// Capture more detail in crash dumps for beta and dev channel builds.
- if (channel_string == L"dev" || channel_string == L"beta" ||
- channel_string == GoogleChromeSxSDistribution::ChannelName())
+ if (channel_name == L"dev" || channel_name == L"beta" ||
+ channel_name == GoogleChromeSxSDistribution::ChannelName())
dump_type = kLargerDumpType;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698