WebSocket Pepper API: in process API base implementation

ppapi/tests/test_websocket.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ppapi/tests/test_websocket.h"
+
+#include "ppapi/c/dev/ppb_websocket_dev.h"
+#include "ppapi/cpp/instance.h"
+#include "ppapi/cpp/module.h"
+#include "ppapi/tests/testing_instance.h"
+
+REGISTER_TEST_CASE(WebSocket);
+
+bool TestWebSocket::Init() {
+  websocket_interface_ = reinterpret_cast<PPB_WebSocket_Dev const*>(

[dmichael (off chromium), 2011/11/18 16:22:21]

static_cast (okay to do in next CL)

[Takashi Toyoshima, 2011/11/19 00:01:19]

Fixed in http://codereview.chromium.org/8558017/.

+      pp::Module::Get()->GetBrowserInterface(PPB_WEBSOCKET_DEV_INTERFACE));
+  return !!websocket_interface_;
+}
+
+void TestWebSocket::RunTests(const std::string& filter) {
+  instance_->LogTest("Create", TestCreate());
+  instance_->LogTest("IsWebSocket", TestIsWebSocket());
+}
+
+std::string TestWebSocket::TestCreate() {
+  PP_Resource rsrc = websocket_interface_->Create(instance_->pp_instance());
+  if (!rsrc)
+    return "Could not create websocket via C interface";

[dmichael (off chromium), 2011/11/18 16:22:21]

For what it's worth, we usually just user the 'ASSERT' macros that are in
test_case.h.

I had assumed you did this to get more meaningful error messages, but now I'm
guessing you just copied from an older test. If it's important to you to get
this error instead of a file and line number, I guess it's okay. But it might be
nice to prefer ASSERTs for consistency (and to make it more gtesty).

(Okay to do in next CL).

[Takashi Toyoshima, 2011/11/19 00:01:19]

Also fixed in http://codereview.chromium.org/8558017/.
That change is not finished. But I'm happy if you could look into quickly.
I'm not sure on pepper related stuff, PP_Var's reference count handling, and
object conversion to WebKit specific objects.

I could take review on WebSocket specific code by yutak@.
He wrote WebCore version of WebSocket and one of OWNERS on net/websockets.
He works in the same timezone with me. So, I'd work with him at next Japanese
Monday.

+
+  PASS();
+}
+
+std::string TestWebSocket::TestIsWebSocket() {
+  // Test that a NULL resource isn't a websocket.
+  pp::Resource null_resource;
+  if (websocket_interface_->IsWebSocket(null_resource.pp_resource()))
+    return "Null resource was reported as a valid websocket";
+
+  PP_Resource ws = websocket_interface_->Create(instance_->pp_instance());
+  if (!websocket_interface_->IsWebSocket(ws))
+    return "websocket was reported as an invalid websocket";
+
+  PASS();
+}