Issue 857003: Probe number dictionaries in generated code on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 857003: Probe number dictionaries in generated code on ia32. (Closed)

Created:
10 years, 9 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Probe number dictionaries in generated code on ia32. With my previous change to limit memory for object literals, we get more slow-case elements and this makes up for the slowdown when loading from those slow-case elements. The most complicated part here is the computation of the integer hash code. We might want to simplify the integer hash function. Committed: http://code.google.com/p/v8/source/detail?r=4109

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -1 line)			Patch
	M	src/ia32/ic-ia32.cc	View	1 2	4 chunks	+130 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/857003/diff/3001/4001 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/857003/diff/3001/4001#newcode245 src/ia32/ic-ia32.cc:245: const int kDetailsOffset = kElementsStartOffset + 2 * ...

10 years, 9 months ago (2010-03-12 07:59:45 UTC) #2

Mads Ager (chromium)

10 years, 9 months ago (2010-03-12 08:20:51 UTC) #3

http://codereview.chromium.org/857003/diff/3001/4001
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/857003/diff/3001/4001#newcode245
src/ia32/ic-ia32.cc:245: const int kDetailsOffset = kElementsStartOffset + 2 *
kPointerSize;
On 2010/03/12 07:59:45, Søren Gjesse wrote:
> ASSERT(NORMAL == 0)?

Done.

http://codereview.chromium.org/857003/diff/3001/4001#newcode248
src/ia32/ic-ia32.cc:248: __ j(not_zero, miss);
On 2010/03/12 07:59:45, Søren Gjesse wrote:
> Shouldn't the DeletedField of the details be checked here as well?

We don't have to.  When deleting an element, we clear the key as well so we will
fail before getting here.

Expand Messages | Collapse Messages