Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8570026: Rearrange the input APIs into more suitable groupings. (Closed)

Created:
9 years, 1 month ago by Zachary Kuznia
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., mihaip+watch_chromium.org, Aaron Boodman, arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Rearrange the input APIs into more suitable groupings. BUG=chromium-os:23058 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110655

Patch Set 1 #

Patch Set 2 : Code Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -150 lines) Patch
M chrome/browser/extensions/extension_input_api.h View 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_input_ime_api.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_input_ime_api.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_input_ui_api.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_input_ui_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/keyboard/common.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/keyboard/ime.js View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/keyboard/layout_handwriting_vk.js View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/keyboard/main.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 5 chunks +81 lines, -72 lines 0 comments Download
M chrome/common/extensions/docs/experimental.inputUI.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/experimental.inputUI.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/schema_generated_bindings.js View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/input/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/input/test.js View 10 chunks +11 lines, -11 lines 0 comments Download
M chrome/test/data/extensions/api_test/input_ime/background.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/input_ime/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/input_ui/chromeos_touch/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/input_ui/chromeos_touch/test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/input_ui/other/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/input_ui/other/test.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zachary Kuznia
9 years, 1 month ago (2011-11-16 07:27:14 UTC) #1
Matt Perry
rubber-stamp LGTM Do you have an sample extensions that need updating?
9 years, 1 month ago (2011-11-16 19:57:33 UTC) #2
Yusuke Sato
lgtm
9 years, 1 month ago (2011-11-17 06:48:05 UTC) #3
bryeung
9 years, 1 month ago (2011-11-17 21:49:43 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698