Enable content component (again!).

Enable content component (again!).

This version fixes a problem with the windows incremental linking build. We can't incrementally link chrome when content is being built as a DLL because chrome links in webkit_glue and webkit_glue depends on symbols defined in content. We can remove this when we fix glue.

R=jam@chromium.org
BUG=90442, 98755
.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110360

[jam, 2011-11-16 16:51:45]

Can you explain, at least in the cl description, why content has to be built
statically if incremental linking is used? I thought we don't use incremental
linking on Windows (but apparently we do!).

[tommi (sloooow) - chröme, 2011-11-16 17:01:27]

Won't this mean that those that use shared+incremental linking can
unknowingly break the shared build?
Do we perhaps have a plan to stop supporting incremental builds on Windows?

On Wed, Nov 16, 2011 at 5:51 PM, <jam@chromium.org> wrote:

> Can you explain, at least in the cl description, why content has to be
> built
> statically if incremental linking is used? I thought we don't use
> incremental
> linking on Windows (but apparently we do!).
>
>
http://codereview.chromium.**org/8570024/<http://codereview.chromium.org/8570...
>

[Dirk Pranke, 2011-11-16 17:58:35]

On Wed, Nov 16, 2011 at 8:51 AM,  <jam@chromium.org> wrote:
> Can you explain, at least in the cl description, why content has to be built
> statically if incremental linking is used? I thought we don't use
> incremental
> linking on Windows (but apparently we do!).
>
> http://codereview.chromium.org/8570024/
>

Will do.

On Wed, Nov 16, 2011 at 9:01 AM, Tommi <tommi@chromium.org> wrote:
> Won't this mean that those that use shared+incremental linking can
> unknowingly break the shared build?

I think there's a small chance of it, but the normal shared builders
should catch things. I hope to get more of them.

> Do we perhaps have a plan to stop supporting incremental builds on Windows?
>

Actually, I would prefer to make incremental linking work better if we
can, since it provides such a productivity boost.

The problem in this case is the circular dependencies between chrome,
content, and glue. They will be fixed when I can turn glue into a DLL,
at which point we can build content as a DLL as well even in the
incremental build.

[jam, 2011-11-16 20:43:51]

lgtm

I still don't understand why content dll breaks incremental linking, but I defer
to you.