Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 857002: Reland 4068 which wrapped Array methods into native builtins (reverted in 4075). (Closed)

Created:
10 years, 9 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reland 4068 which wrapped Array methods into native builtins (reverted in 4075). Committed: http://code.google.com/p/v8/source/detail?r=4104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -163 lines) Patch
M src/arm/stub-cache-arm.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +51 lines, -42 lines 0 comments Download
M src/builtins.cc View 12 chunks +51 lines, -27 lines 0 comments Download
M src/contexts.h View 3 chunks +0 lines, -8 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +1 line, -14 lines 0 comments Download
M src/ic.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/top.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/top.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Mads, may you have a look? It's almost revert of 4075. One thing I changed: ...
10 years, 9 months ago (2010-03-11 06:57:05 UTC) #1
Mads Ager (chromium)
10 years, 9 months ago (2010-03-11 07:18:33 UTC) #2
LGTM, thanks for finding the unrelated issue that this triggered!

Powered by Google App Engine
This is Rietveld 408576698