Aura: windows in aura should honor Widget::InitParams::accept_events

Aura: windows in aura should honor Widget::InitParams::accept_events

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110406

[Ben Goodger (Google), 2011-11-15 21:29:38]

What kind of widgets set can_accept_events = false?

[varunjain, 2011-11-15 21:31:46]

On 2011/11/15 21:29:38, Ben Goodger (Google) wrote:
> What kind of widgets set can_accept_events = false?

at least the tooltips and the widget that flies around during a drag and drop.
Also some decorative popups

[varunjain, 2011-11-15 21:35:11]

On 2011/11/15 21:31:46, varunjain wrote:
> On 2011/11/15 21:29:38, Ben Goodger (Google) wrote:
> > What kind of widgets set can_accept_events = false?
> 
> at least the tooltips and the widget that flies around during a drag and drop.
> Also some decorative popups

Some example decorative popups that do that are
TabStrip::DropInfo::arrow_window_, StatusBubbleViews

[Ben Goodger (Google), 2011-11-15 22:10:52]

http://codereview.chromium.org/8570011/diff/19/ui/aura/window_delegate.h
File ui/aura/window_delegate.h (right):

http://codereview.chromium.org/8570011/diff/19/ui/aura/window_delegate.h#newc...
ui/aura/window_delegate.h:59: virtual bool ShouldAcceptEvents() { return true; }
Everything else on this interface is pure virtual. 

Instead, can we add an ignores_events_ field to Window?

[varunjain, 2011-11-15 22:14:19]

On 2011/11/15 22:10:52, Ben Goodger (Google) wrote:
> http://codereview.chromium.org/8570011/diff/19/ui/aura/window_delegate.h
> File ui/aura/window_delegate.h (right):
> 
>
http://codereview.chromium.org/8570011/diff/19/ui/aura/window_delegate.h#newc...
> ui/aura/window_delegate.h:59: virtual bool ShouldAcceptEvents() { return true;
}
> Everything else on this interface is pure virtual. 
> 
> Instead, can we add an ignores_events_ field to Window?

I actually did it that way in Patch Set 1 :)
But I think adding it to the delegate is more in line with other things like
ShouldActivate(). If keeping WindowDelegate pure virtual is the only concern, I
can add implementation to all concrete children

[Ben Goodger (Google), 2011-11-16 00:05:07]

Please add an implementation to delegates then.

[varunjain, 2011-11-16 00:15:46]

On 2011/11/16 00:05:07, Ben Goodger (Google) wrote:
> Please add an implementation to delegates then.

Done

[Ben Goodger (Google), 2011-11-16 00:22:47]

So I thought about this more and I actually don't think this is like
ShouldActivate. ShouldActivate is a state that can change over the lifetime of
the window. This is configuration that will never change (since it's only
specified in initparams). As such I don't think it should be a delegate method
and instead just configuration on the window. Sorry for the runaround.

[varunjain, 2011-11-16 20:36:38]

On 2011/11/16 00:22:47, Ben Goodger (Google) wrote:
> So I thought about this more and I actually don't think this is like
> ShouldActivate. ShouldActivate is a state that can change over the lifetime of
> the window. This is configuration that will never change (since it's only
> specified in initparams). As such I don't think it should be a delegate method
> and instead just configuration on the window. Sorry for the runaround.

Done

[Ben Goodger (Google), 2011-11-16 21:34:22]

lgtm

[commit-bot: I haz the power, 2011-11-16 22:15:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/8570011/7001

[commit-bot: I haz the power, 2011-11-17 00:52:22]

Change committed as 110406