Moving media-related files from webkit/glue/ to webkit/media/.

Moving media-related files from webkit/glue/ to webkit/media/.

Files under webkit/media/ are now under their very own webkit_media namespace.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110438

[scherkus (not reviewing), 2011-11-15 20:57:26]

Not sure what the intent was behind http://crrev.com/109992 was but in any case
feel free to voice objections and/or alternatives.

[tony, 2011-11-15 22:28:15]

On 2011/11/15 20:57:26, scherkus wrote:
> Not sure what the intent was behind http://crrev.com/109992 was but in any
case
> feel free to voice objections and/or alternatives.

An alternate way would be to move webkit/glue/media and webkit/glue/webmedia*
into webkit/media and put a separate OWNERS file there.  That seems like what
appcache, database, fileapi and a few other features are doing.

[scherkus (not reviewing), 2011-11-15 22:30:02]

On 2011/11/15 22:28:15, tony wrote:
> On 2011/11/15 20:57:26, scherkus wrote:
> > Not sure what the intent was behind http://crrev.com/109992 was but in any
> case
> > feel free to voice objections and/or alternatives.
> 
> An alternate way would be to move webkit/glue/media and webkit/glue/webmedia*
> into webkit/media and put a separate OWNERS file there.  That seems like what
> appcache, database, fileapi and a few other features are doing.

Yeah I thought about that as well but I wasn't sure what constituted a
webkit/foo folder versus stuff that has to go under webkit/glue/*

Is it safe to say that _everything_ under webkit/ is "glue" and that
webkit/glue/ itself contains stuff that doesn't warrant a webkit/foo folder?

[darin (slow to review), 2011-11-16 04:50:45]

On Tue, Nov 15, 2011 at 2:30 PM, <scherkus@chromium.org> wrote:

> On 2011/11/15 22:28:15, tony wrote:
>
>> On 2011/11/15 20:57:26, scherkus wrote:
>> > Not sure what the intent was behind http://crrev.com/109992 was but in
>> any
>> case
>> > feel free to voice objections and/or alternatives.
>>
>
>  An alternate way would be to move webkit/glue/media and
>> webkit/glue/webmedia*
>> into webkit/media and put a separate OWNERS file there.  That seems like
>> what
>> appcache, database, fileapi and a few other features are doing.
>>
>
> Yeah I thought about that as well but I wasn't sure what constituted a
> webkit/foo folder versus stuff that has to go under webkit/glue/*
>
> Is it safe to say that _everything_ under webkit/ is "glue" and that
> webkit/glue/ itself contains stuff that doesn't warrant a webkit/foo
> folder?
>
>
I think it's probably safe to say that webkit/glue is a dumping ground that
is unfortunate :-/

I'd really like to see webkit/glue disappear someday.  I like the idea of
moving media specific files into a media specific folder.  This way OWNERS
files can work for us.

The intent of the "set noparent" CL was to force OWNERS files in src/webkit
to be respected, which will force us to improve the structure of src/webkit
and add new OWNERS files :-D

-Darin



>
>
http://codereview.chromium.**org/8570010/<http://codereview.chromium.org/8570...
>

[scherkus (not reviewing), 2011-11-16 22:58:37]

Agreed about the dumping ground that is webkit/glue/

tony: I removed you as a reviewer
darin: would mind taking a look through this?

Notable changes include adding a webkit_media namespace.  I was mostly following
what other webkit/* folders were doing so I'd like to hear whether this approach
is OK.

An alternative would be to put everything under webkit/* in a broader "webkit"
namespace (similar to content) instead of having subdivided namespaces on a
per-folder basis.

[darin (slow to review), 2011-11-17 05:03:38]

LGTM