Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 8570007: Reduce race potential for lazy testing initialization of profiler (Closed)

Created:
9 years, 1 month ago by jar (doing other things)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Reduce race potential for lazy testing initialization of profiler Initialization of the profiler is supposed to happen while single threaded. The tests however often skip affirmative initialization, and rely on lazy initialization. This CL tightens up that process, to reduce changes of races (even benign races) during testing. I also added a suppression for examination of the state, which is always a benign race. At initialization time we rely on a lock (now) to ensure race freedom (if we get a racy value of state). r=rtenneti Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110180

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M base/tracked_objects.cc View 1 1 chunk +23 lines, -8 lines 0 comments Download
M tools/valgrind/tsan/suppressions.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jar (doing other things)
9 years, 1 month ago (2011-11-15 19:21:45 UTC) #1
jar (doing other things)
Changes per verbal suggestions by rtenneti
9 years, 1 month ago (2011-11-15 19:35:24 UTC) #2
ramant (doing other things)
9 years, 1 month ago (2011-11-15 19:39:54 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698