Issue 8570005: Make subprocess2.Popen a class instead of a function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8570005: Make subprocess2.Popen a class instead of a function. (Closed)

Created:
9 years, 1 month ago by Marc-Antoine Ruel (Google)

Modified:
9 years, 1 month ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Make subprocess2.Popen a class instead of a function. This will be necessary to override member functions eventually. It also better replicates what subprocess.Popen is. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111530

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -68 lines)			Patch
	M	subprocess2.py	View		2 chunks	+55 lines, -54 lines	0 comments	Download
	M	tests/subprocess2_test.py	View		4 chunks	+20 lines, -14 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@google.com/8570005/1

9 years, 1 month ago (2011-11-24 15:16:57 UTC) #3

Change committed as 111530