Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 8569015: Revert 110765 - Fix DownloadTests and change cros/aura to use shelf (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_util.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_browsertest.cc
===================================================================
--- chrome/browser/download/save_page_browsertest.cc (revision 110765)
+++ chrome/browser/download/save_page_browsertest.cc (working copy)
@@ -109,8 +109,6 @@
#endif
void CheckDownloadUI(const FilePath& download_path) const {
- // Expectations must be in sync with the implementation in
- // Browser::OnStartDownload().
#if defined(OS_CHROMEOS)
const ActiveDownloadsUI::DownloadList& downloads = GetDownloads();
EXPECT_EQ(downloads.size(), 1U);
@@ -123,11 +121,8 @@
}
}
EXPECT_TRUE(found);
-#elif !defined(USE_AURA)
- EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
#else
- // TODO(jamescook): Downloads UI for non-ChromeOS Aura, crbug.com/103488
- NOTIMPLEMENTED();
+ EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
#endif
}
« no previous file with comments | « chrome/browser/download/download_util.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698