Issue 8569011: Update |current_input_method_| before notifying observers to fix Aura browser_tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8569011: Update |current_input_method_| before notifying observers to fix Aura browser_tests (Closed)

Created:
9 years, 1 month ago by Yusuke Sato

Modified:
9 years, 1 month ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update |current_input_method_| before notifying observers to fix Aura browser_tests. Otherwise, InputMethodMenu might crash with DCHECK if the following conditions are all met: - Debug build - An instance of InputMethodMenu or InputMethodMenuButton is created before the first SetImeConfig() call is made. Note that aura_shell::Shell::Init() does this. - More than 1 layout IDs are passed to SetImeConfig(). Currently, on Chrome (or on browser_tests) start up, 5-6 layouts (Qwerty, Dvorak, ..) are passed by default. BUG=chromium:103503 TEST=ran try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111049

Patch Set 1 : review #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/chromeos/input_method/input_method_manager.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8569011/5001

9 years, 1 month ago (2011-11-21 23:00:56 UTC) #3

Change committed as 111049

Expand Messages | Collapse Messages