Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: content/browser/child_process_security_policy.cc

Issue 8569006: Add UMA stats for per-child file permissions count (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/child_process_security_policy.cc
diff --git a/content/browser/child_process_security_policy.cc b/content/browser/child_process_security_policy.cc
index 1433218992fd15ca079e33cfbf587a30ec620108..c2ea66cb27467b7d4f64f2555e04ece3ed47e202 100644
--- a/content/browser/child_process_security_policy.cc
+++ b/content/browser/child_process_security_policy.cc
@@ -6,6 +6,7 @@
#include "base/file_path.h"
#include "base/logging.h"
+#include "base/metrics/histogram.h"
#include "base/platform_file.h"
#include "base/stl_util.h"
#include "base/string_util.h"
@@ -33,6 +34,8 @@ class ChildProcessSecurityPolicy::SecurityState {
can_read_raw_cookies_(false) { }
~SecurityState() {
scheme_policy_.clear();
+ UMA_HISTOGRAM_COUNTS("ChildProcessSecurityPolicy.PerChildFilePermissions",
+ file_permissions_.size());
}
// Grant permission to request URLs with the specified scheme.
@@ -47,7 +50,10 @@ class ChildProcessSecurityPolicy::SecurityState {
// Grant certain permissions to a file.
void GrantPermissionsForFile(const FilePath& file, int permissions) {
- file_permissions_[file.StripTrailingSeparators()] |= permissions;
+ FilePath stripped = file.StripTrailingSeparators();
+ file_permissions_[stripped] |= permissions;
+ UMA_HISTOGRAM_COUNTS("ChildProcessSecurityPolicy.FilePermissionPathLength",
+ stripped.value().size());
}
// Revokes all permissions granted to a file.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698