Issue 8568044: aura: Re-enable XInput2 events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8568044: aura: Re-enable XInput2 events. (Closed)

Created:
9 years, 1 month ago by sadrul

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, DaveMoore

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Re-enable XInput2 events. It turns out that the position information in an event for a slave device reported by X is always slightly behind than the actual position. However, it turns out that the valuators do contain the correct information. So get the event location from the valuator. BUG=103981 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111016

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
	M	ui/aura/desktop_host_linux.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
	M	ui/base/x/events_x.cc	View	1	1 chunk	+25 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

http://codereview.chromium.org/8568044/diff/1/ui/base/x/events_x.cc File ui/base/x/events_x.cc (right): http://codereview.chromium.org/8568044/diff/1/ui/base/x/events_x.cc#newcode257 ui/base/x/events_x.cc:257: // Prepare to be revolted. It's not all that ...

9 years, 1 month ago (2011-11-21 01:30:29 UTC) #1

LGTM

Expand Messages | Collapse Messages