Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: tools/checkperms/checkperms.py

Issue 8568043: Whitelisting scons + naclsdk in checkperms so that the nacl sdk (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Makes sure files have the right permissions. 6 """Makes sure files have the right permissions.
7 7
8 Some developers have broken SCM configurations that flip the svn:executable 8 Some developers have broken SCM configurations that flip the svn:executable
9 permission on for no good reason. Unix developers who run ls --color will then 9 permission on for no good reason. Unix developers who run ls --color will then
10 see .cc files in green and get confused. 10 see .cc files in green and get confused.
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 ] 81 ]
82 82
83 # File names that are always whitelisted. (These are all autoconf spew.) 83 # File names that are always whitelisted. (These are all autoconf spew.)
84 WHITELIST_FILENAMES = set(( 84 WHITELIST_FILENAMES = set((
85 'config.guess', 85 'config.guess',
86 'config.sub', 86 'config.sub',
87 'configure', 87 'configure',
88 'depcomp', 88 'depcomp',
89 'install-sh', 89 'install-sh',
90 'missing', 90 'missing',
91 'mkinstalldirs' 91 'mkinstalldirs',
92 'scons',
93 'naclsdk',
92 )) 94 ))
93 95
94 # File paths that contain these regexps will be whitelisted as well. 96 # File paths that contain these regexps will be whitelisted as well.
95 WHITELIST_REGEX = [ 97 WHITELIST_REGEX = [
96 re.compile('/third_party/openssl/'), 98 re.compile('/third_party/openssl/'),
97 re.compile('/third_party/sqlite/'), 99 re.compile('/third_party/sqlite/'),
98 re.compile('/third_party/xdg-utils/'), 100 re.compile('/third_party/xdg-utils/'),
99 re.compile('/third_party/yasm/source/patched-yasm/config'), 101 re.compile('/third_party/yasm/source/patched-yasm/config'),
100 re.compile('/third_party/ffmpeg/patched-ffmpeg/tools'), 102 re.compile('/third_party/ffmpeg/patched-ffmpeg/tools'),
101 ] 103 ]
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 success = CheckDirectory(start_dir) 329 success = CheckDirectory(start_dir)
328 if not success: 330 if not success:
329 print '\nFAILED\n' 331 print '\nFAILED\n'
330 return 1 332 return 1
331 print '\nSUCCESS\n' 333 print '\nSUCCESS\n'
332 return 0 334 return 0
333 335
334 336
335 if '__main__' == __name__: 337 if '__main__' == __name__:
336 sys.exit(main(sys.argv)) 338 sys.exit(main(sys.argv))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698