Issue 8568041: [Sync] Add type conversion constructor for WeakHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8568041: [Sync] Add type conversion constructor for WeakHandle (Closed)

Created:
9 years, 1 month ago by akalin

Modified:
9 years, 1 month ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Add type conversion constructor for WeakHandle This allows the use of e.g.: WeakHandle<T> weak_handle = MakeWeakHandle(WeakPtr<U>()); as long as U is convertible to T, instead of: WeakHandle<T> weak_handle = WeakHandle<T>(WeakPtr<U>()); Fix all callers. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110436

Patch Set 1 #

Patch Set 2 : Fix a couple more callers #

Patch Set 3 : Clean up tests a bit #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -12 lines)			Patch
M	chrome/browser/sync/internal_api/sync_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/js/js_test_util.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/notifier/chrome_invalidation_client_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/sync_js_controller.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/util/weak_handle.h	View	1 2	3 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/util/weak_handle_unittest.cc	View	1 2	3 chunks	+64 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_internals_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/8568041/10

9 years, 1 month ago (2011-11-17 00:07:31 UTC) #3

Change committed as 110436

Expand Messages | Collapse Messages