Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: net/base/x509_certificate_win.cc

Issue 8568040: Refuse to accept certificate chains containing any RSA public key smaller (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/x509_certificate_win.cc
===================================================================
--- net/base/x509_certificate_win.cc (revision 110129)
+++ net/base/x509_certificate_win.cc (working copy)
@@ -1153,4 +1153,39 @@
length);
}
+// static
+void X509Certificate::GetPublicKeyInfo(OSCertHandle cert_handle,
+ size_t* size_bits,
+ PublicKeyType* type) {
+ PCCRYPT_OID_INFO oid_info = CryptFindOIDInfo(
+ CRYPT_OID_INFO_OID_KEY,
+ cert_handle->pCertInfo->SubjectPublicKeyInfo.Algorithm.pszObjId,
+ CRYPT_SIGN_ALG_OID_GROUP_ID);
+ CHECK(oid_info);
+ CHECK(oid_info->dwGroupId == CRYPT_SIGN_ALG_OID_GROUP_ID);
+ CHECK(oid_info->ExtraInfo.cbData >= sizeof(DWORD));
+ DWORD id = *reinterpret_cast<DWORD*>(oid_info->ExtraInfo.pbData);
+
+ *size_bits = CertGetPublicKeyLength(
+ X509_ASN_ENCODING | PKCS_7_ASN_ENCODING,
+ &cert_handle->pCertInfo->SubjectPublicKeyInfo);
+
+ switch (id) {
+ case CALG_RSA_SIGN:
+ *type = kPublicKeyTypeRSA;
+ break;
+ case CALG_DSS_SIGN:
+ *type = kPublicKeyTypeDSA;
+ break;
+ case CALG_ECDSA:
+ *type = kPublicKeyTypeECDSA;
+ break;
+ case CALG_ECDH:
+ *type = kPublicKeyTypeECDH;
+ break;
+ default:
+ *type = kPublicKeyTypeUnknown;
+ }
+}
+
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698