net/base/cert_status_flags.cc - Issue 8568040: Refuse to accept certificate chains containing any RSA public key smaller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/cert_status_flags.cc

Issue 8568040: Refuse to accept certificate chains containing any RSA public key smaller (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/cert_status_flags.cc

===================================================================

--- net/base/cert_status_flags.cc (revision 110129)

+++ net/base/cert_status_flags.cc (working copy)

@@ -41,6 +41,8 @@

return CERT_STATUS_INVALID;

case ERR_CERT_WEAK_SIGNATURE_ALGORITHM:

return CERT_STATUS_WEAK_SIGNATURE_ALGORITHM;

+ case ERR_CERT_WEAK_KEY:

+ return CERT_STATUS_WEAK_KEY;

wtc 2011/11/17 02:52:18 Nit: since the ordering of the cases doesn't matte

case ERR_CERT_NOT_IN_DNS:

return CERT_STATUS_NOT_IN_DNS;

default:

@@ -57,6 +59,8 @@

return ERR_CERT_REVOKED;

if (cert_status & CERT_STATUS_INVALID)

return ERR_CERT_INVALID;

+ if (cert_status & CERT_STATUS_WEAK_KEY)

+ return ERR_CERT_WEAK_KEY;

// Recoverable errors

if (cert_status & CERT_STATUS_AUTHORITY_INVALID)

« no previous file with comments | « net/base/cert_status_flags.h ('k') | net/base/net_error_list.h » ('j') | net/base/net_error_list.h » ('J')