Refuse to accept certificate chains containing any RSA public key smaller

net/base/cert_status_flags.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/cert_status_flags.h"
 
 #include "base/logging.h"
 #include "net/base/net_errors.h"
 
 namespace net {
@@ skipping 23 matching lines @@
     // We added the ERR_CERT_CONTAINS_ERRORS error code when we were using
     // WinInet, but we never figured out how it differs from ERR_CERT_INVALID.
     // We should not use ERR_CERT_CONTAINS_ERRORS in new code.
     case ERR_CERT_CONTAINS_ERRORS:
       NOTREACHED();
       // Falls through.
     case ERR_CERT_INVALID:
       return CERT_STATUS_INVALID;
     case ERR_CERT_WEAK_SIGNATURE_ALGORITHM:
       return CERT_STATUS_WEAK_SIGNATURE_ALGORITHM;
+    case ERR_CERT_WEAK_KEY:
+      return CERT_STATUS_WEAK_KEY;
     case ERR_CERT_NOT_IN_DNS:
       return CERT_STATUS_NOT_IN_DNS;
     default:
       return 0;
   }
 }
 
 int MapCertStatusToNetError(CertStatus cert_status) {
   // A certificate may have multiple errors.  We report the most
   // serious error.
 
   // Unrecoverable errors
   if (cert_status & CERT_STATUS_REVOKED)
     return ERR_CERT_REVOKED;
   if (cert_status & CERT_STATUS_INVALID)
     return ERR_CERT_INVALID;
 
   // Recoverable errors
   if (cert_status & CERT_STATUS_AUTHORITY_INVALID)
     return ERR_CERT_AUTHORITY_INVALID;
   if (cert_status & CERT_STATUS_COMMON_NAME_INVALID)
     return ERR_CERT_COMMON_NAME_INVALID;
   if (cert_status & CERT_STATUS_WEAK_SIGNATURE_ALGORITHM)
     return ERR_CERT_WEAK_SIGNATURE_ALGORITHM;
+  if (cert_status & CERT_STATUS_WEAK_KEY)
+    return ERR_CERT_WEAK_KEY;

[Ryan Sleevi, 2011/12/13 23:54:16]

Just a reminder that you will want to update the localized error pages in a
subsequent CL, especially if you wish an interstitial to show to allow the user
to recover (Line 63)

   if (cert_status & CERT_STATUS_DATE_INVALID)
     return ERR_CERT_DATE_INVALID;
 
   // Unknown status.  Give it the benefit of the doubt.
   if (cert_status & CERT_STATUS_UNABLE_TO_CHECK_REVOCATION)
     return ERR_CERT_UNABLE_TO_CHECK_REVOCATION;
   if (cert_status & CERT_STATUS_NO_REVOCATION_MECHANISM)
     return ERR_CERT_NO_REVOCATION_MECHANISM;
   if (cert_status & CERT_STATUS_NOT_IN_DNS)
     return ERR_CERT_NOT_IN_DNS;
 
   NOTREACHED();
   return ERR_UNEXPECTED;
 }
 
 }  // namespace net