Refuse to accept certificate chains containing any RSA public key smaller

net/base/x509_certificate_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/x509_certificate.h"
 
 #define PRArenaPool PLArenaPool  // Required by <blapi.h>.
 #include <blapi.h>  // Implement CalculateChainFingerprint() with NSS.
 
 #include "base/lazy_instance.h"
@@ skipping 1135 matching lines @@
   // private key.
   if (!CertSerializeCertificateStoreElement(cert_handle, 0, &buffer[0],
                                             &length)) {
     return false;
   }
 
   return pickle->WriteData(reinterpret_cast<const char*>(&buffer[0]),
                            length);
 }
 
+//static
+void X509Certificate::GetPublicKeyInfo(OSCertHandle cert_handle,
+                                       size_t* size_bits,
+                                       PublicKeyType* type) {
+  *size_bits = CertGetPublicKeyLength(
+      X509_ASN_ENCODING | PKCS_7_ASN_ENCODING,
+      cert_handle->pCertInfo->SubjectPublicKeyInfo);
+
+  PCCRYPT_OID_INFO oid_info = CryptFindOIDInfo(
+      CRYPT_OID_INFO_OID_KEY,
+      cert_handle->pCertInfo->SubjectPublicKeyInfo->Algorithm->pszObjId,
+      CRYPT_SIGN_ALG_OID_GROUP_ID);
+  CHECK(CRYPT_OID_INFO.dwGroupId == CRYPT_SIGN_ALG_OID_GROUP_ID);

[Ryan Sleevi, 2011/11/16 03:46:11]

nit: oid_info->dwGroupId (and the next two lines)

+  CHECK(CRYPT_OID_INFO.ExtraInfo.cbData >= sizeof(DWORD));
+  DWORD id = *reinterpret_cast<DWORD*>(CRYPT_OID_INFO.ExtraInfo.pbData);
+
+  switch (id) {
+    case CALG_RSA_SIGN:
+      *type = PublicKeyType::RSA;
+      break;
+    case CALG_DSS_SIGN:
+      *type = PublicKeyType::DSA;
+      break;
+    case CALG_ECDSA:
+      *type = PublicKeyType::ECDSA;
+      break;
+    default:
+      *type = PublicKeyType::None;
+  }
+}
+
 }  // namespace net