Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 8568038: Create HostList class to facilitate future work. (Closed)

Created:
9 years, 1 month ago by Jamie
Modified:
9 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Create HostList class to facilitate future work. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110400

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -112 lines) Patch
M remoting/remoting.gyp View 3 chunks +3 lines, -2 lines 0 comments Download
M remoting/webapp/me2mom/choice.html View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/me2mom/client_screen.js View 1 chunk +3 lines, -2 lines 2 comments Download
M remoting/webapp/me2mom/home_screen.js View 5 chunks +3 lines, -108 lines 2 comments Download
A remoting/webapp/me2mom/host_list.js View 1 chunk +139 lines, -0 lines 0 comments Download
M remoting/webapp/me2mom/remoting.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jamie
PTAL.
9 years, 1 month ago (2011-11-16 01:18:34 UTC) #1
Wez
LGTM, although it seems strange that the HostList isn't really the host list - it ...
9 years, 1 month ago (2011-11-16 21:41:22 UTC) #2
Jamie
9 years, 1 month ago (2011-11-16 22:09:09 UTC) #3
http://codereview.chromium.org/8568038/diff/1/remoting/webapp/me2mom/client_s...
File remoting/webapp/me2mom/client_screen.js (right):

http://codereview.chromium.org/8568038/diff/1/remoting/webapp/me2mom/client_s...
remoting/webapp/me2mom/client_screen.js:396: /** @type {remoting.Host} */
On 2011/11/16 21:41:23, Wez wrote:
> Does this annotation apply to the var definition?

Yes. For some reason, JSCompiler can't infer the type of an array element from
the type of the array, possibly because it has to account for out-of-bounds
conditions.

http://codereview.chromium.org/8568038/diff/1/remoting/webapp/me2mom/home_scr...
File remoting/webapp/me2mom/home_screen.js (right):

http://codereview.chromium.org/8568038/diff/1/remoting/webapp/me2mom/home_scr...
remoting/webapp/me2mom/home_screen.js:56: function parseHostListResponse_(xhr) {
On 2011/11/16 21:41:23, Wez wrote:
> Would it make sense to move the XHR dispatch and parsing of the response into
> remoting.hostList, too?

You could make a case either way. I think I'd prefer to leave it here for now to
keep the HostList class clean while I implement new stuff. Since it is going to
have to do some xhr stuff to implement rename and delete, it probably makes
sense to move this stuff into it as well at a later date.

Powered by Google App Engine
This is Rietveld 408576698