Issue 8568036: Remove about:tracking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8568036: Remove about:tracking. (Closed)

Created:
9 years, 1 month ago by eroman

Modified:
9 years, 1 month ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, arv (Not doing code reviews), brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove about:tracking. It has been subsumed by about:profiler. I also added a button to about:profiler that matches the behavior of "about:tracking/reset" (nukes the tracked objects). That way there shouldn't be any functionality loss in deleting about:tracking. BUG=100992 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110252

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : moar #

Patch Set 4 : less #

Patch Set 5 : add missing file profiler.js #

Patch Set 6 : remove an unused header #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -804 lines)			Patch
M	base/tracked_objects.h	View	1 2	3 chunks	+0 lines, -157 lines	0 comments	Download
M	base/tracked_objects.cc	View	1	7 chunks	+0 lines, -615 lines	0 comments	Download
M	base/tracked_objects_unittest.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View	1 2 3 4 5	5 chunks	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/resources/profiler.html	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/profiler.js	View	1 2 3 4	3 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/url_constants.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/8568036/21

9 years, 1 month ago (2011-11-16 03:19:45 UTC) #3

Change committed as 110252

Expand Messages | Collapse Messages