Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 8568033: Re-enable stress sync integration tests (Closed)

Created:
9 years, 1 month ago by Raghu Simha
Modified:
9 years, 1 month ago
CC:
chromium-reviews, ncarter (slow), akalin, tim (not reviewing)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Re-enable stress sync integration tests The stress sync integration tests use 10 sync clients, and were originally flaky due to testserver bugginess. Several fixes have gone in since then, and it might be time to re-enable those tests. Note to future Chromium Sheriffs: If these stress tests do fail or time out in future, feel free to revert this patch. BUG=69604 TEST=sync_integration_tests --gtest_filter=ManyClient* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/sync/test/integration/many_client_bookmarks_sync_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/many_client_passwords_sync_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/many_client_preferences_sync_test.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Raghu Simha
Tim, please review. Thanks.
9 years, 1 month ago (2011-11-16 00:30:54 UTC) #1
Raghu Simha
Try jobs are green so far. http://build.chromium.org/p/tryserver.chromium/builders/win_sync/builds/499 http://build.chromium.org/p/tryserver.chromium/builders/linux_sync/builds/503
9 years, 1 month ago (2011-11-16 00:31:54 UTC) #2
Raghu Simha
+Richard for review.
9 years, 1 month ago (2011-11-16 00:58:34 UTC) #3
rlarocque
On 2011/11/16 00:58:34, rsimha wrote: > +Richard for review. This seems sketchy, but LGTM. Just ...
9 years, 1 month ago (2011-11-16 01:20:40 UTC) #4
Raghu Simha
On 2011/11/16 01:20:40, rlarocque wrote: > This seems sketchy, but LGTM. Just be sure to ...
9 years, 1 month ago (2011-11-16 01:32:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsimha@chromium.org/8568033/1
9 years, 1 month ago (2011-11-16 19:10:43 UTC) #6
commit-bot: I haz the power
Try job failure for 8568033-1 (retry) on win_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-16 21:08:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsimha@chromium.org/8568033/1
9 years, 1 month ago (2011-11-17 01:01:11 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 06:10:36 UTC) #9
Change committed as 110450

Powered by Google App Engine
This is Rietveld 408576698