Call plugin.onIq() only when onIq is not null.

remoting/webapp/me2mom/client_session.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling creation and teardown of a remoting client session.
  *
  * This abstracts a <embed> element and controls the plugin which does the
  * actual remoting work.  There should be no UI code inside this class.  It
@@ skipping 254 matching lines @@
   this.clientJid = remoting.wcs.getJid();
   if (this.clientJid == '') {
     remoting.debug.log('Tried to connect without a full JID.');
   }
   remoting.debug.setJids(this.clientJid, this.hostJid);
   /** @type {remoting.ClientSession} */
   var that = this;
   /** @param {string} stanza The IQ stanza received. */
   var onIq = function(stanza) {
     remoting.debug.logIq(false, stanza);
-    that.plugin.onIq(stanza);
+    if (that.plugin.onIq)

[Wez, 2011/11/19 00:59:14]

Do we want to log something different if there is no onIq(), so we can tell that
the message wasn't sent?

[garykac, 2011/11/19 01:12:49]

+1
We shouldn't be logging the stanza if we didn't actually send it.
Or we should note that we were unable to send the stanza.

[Sergey Ulanov, 2011/11/19 01:30:53]

This function handles incoming messages, not outgoing, i.e. it doesn't send
anything. onIq isn't set here after the plugin has been shut down after
disconnection, so I don't think it's not very important to log this event here.
Added log message anyway.

[Sergey Ulanov, 2011/11/19 01:30:53]

We don't send anything here, it's for incoming messages.

+      that.plugin.onIq(stanza);
   }
   remoting.wcs.setOnIq(onIq);
   that.plugin.connect(this.hostJid, this.hostPublicKey, this.clientJid,
                       this.accessCode);
 };
 
 /**
  * Callback that the plugin invokes to indicate that the connection
  * status has changed.
  */
@@ skipping 122 matching lines @@
   return {
     'video_bandwidth': this.plugin.videoBandwidth,
     'video_frame_rate': this.plugin.videoFrameRate,
     'capture_latency': this.plugin.videoCaptureLatency,
     'encode_latency': this.plugin.videoEncodeLatency,
     'decode_latency': this.plugin.videoDecodeLatency,
     'render_latency': this.plugin.videoRenderLatency,
     'roundtrip_latency': this.plugin.roundTripLatency
   };
 };