Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 8568026: GTK: Always relayout the tab strip when the tab strip bounds change. (Closed)

Created:
9 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, James Hawkins
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Always relayout the tab strip when the tab strip bounds change. TabStripGtk::OnSizeAllocate() could fail to call Layout() or schedule Layout() to be called in the future (and was reusing the code to resize the internal tabs when a single tab was closed). The views implementation of the tabstrip didn't use that path and would always relayout the entire tabstrip on bounds changes. BUG=79094 TEST=Create a window with more than 20 tabs in it. Very slowly shrink the window, one pixel at a time. The min/max/close buttons shouldn't overlap with the new tab button. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110451

Patch Set 1 #

Patch Set 2 : Remove stray mark #

Total comments: 1

Patch Set 3 : coalesce calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 2 5 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
I've tested this in both ltr and rtl modes. I will, as a separate cleanup ...
9 years, 1 month ago (2011-11-15 22:53:55 UTC) #1
Evan Stade
http://codereview.chromium.org/8568026/diff/2001/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right): http://codereview.chromium.org/8568026/diff/2001/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc#newcode2093 chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:2093: layout_factory_.InvalidateWeakPtrs(); I don't get this, why not coalesce calls, ...
9 years, 1 month ago (2011-11-16 04:13:54 UTC) #2
Elliot Glaysher
ptal
9 years, 1 month ago (2011-11-16 17:59:49 UTC) #3
Evan Stade
lgtm assuming this doesn't cause a large increase in cpu usage during resize
9 years, 1 month ago (2011-11-17 00:55:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8568026/5001
9 years, 1 month ago (2011-11-17 01:03:44 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 06:10:43 UTC) #6
Change committed as 110451

Powered by Google App Engine
This is Rietveld 408576698