Add OVERRIDE to net/.

Add OVERRIDE to net/.

BUG=104314
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110231

[Avi (use Gerrit), 2011-11-15 21:43:21]

You're a net/ owner. All this does is add OVERRIDE everywhere needed. No change
otherwise.

[eroman, 2011-11-15 21:54:10]

LGTM

On Tue, Nov 15, 2011 at 1:43 PM, <avi@chromium.org> wrote:

> Reviewers: eroman,
>
> Message:
> You're a net/ owner. All this does is add OVERRIDE everywhere needed. No
> change
> otherwise.
>
> Description:
> Add OVERRIDE to net/.
>
> BUG=104314
>
>
> Please review this at
http://codereview.chromium.**org/8568021/<http://codereview.chromium.org/8568...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M net/base/address_list_net_log_**param.h
>  M net/base/cert_verifier.h
>  M net/base/cookie_monster_store_**test.h
>  M net/base/cookie_store_test_**helpers.h
>  M net/base/dnsrr_resolver.h
>  M net/base/gzip_filter.h
>  M net/base/host_resolver_impl.h
>  M net/base/listen_socket.h
>  M net/base/listen_socket_**unittest.h
>  M net/base/mock_filter_context.h
>  M net/base/mock_host_resolver.h
>  M net/base/net_log.h
>  M net/base/net_test_suite.h
>  M net/base/sdch_filter.h
>  M net/base/ssl_client_auth_**cache.h
>  M net/base/ssl_config_service_**defaults.h
>  M net/base/test_completion_**callback.h
>  M net/base/test_host_resolver_**observer.h
>  M net/disk_cache/backend_impl.h
>  M net/disk_cache/disk_cache_**test_base.h
>  M net/disk_cache/disk_cache_**test_util.h
>  M net/disk_cache/entry_impl.h
>  M net/disk_cache/in_flight_**backend_io.h
>  M net/disk_cache/mem_backend_**impl.h
>  M net/disk_cache/mem_entry_impl.**h
>  M net/disk_cache/net_log_**parameters.h
>  M net/disk_cache/stats_**histogram.h
>  net/http/disk_cache_based_ssl_**host_info.h
>  net/http/http_auth_filter.h
>  M net/http/http_auth_gssapi_**posix.h
>  net/http/http_auth_handler_**basic.h
>  M net/http/http_auth_handler_**digest.h
>  M net/http/http_auth_handler_**factory.h
>  M net/http/http_auth_handler_**mock.h
>  M net/http/http_auth_handler_**negotiate.h
>  M net/http/http_auth_handler_**ntlm.h
>  M net/http/http_cache.h
>  M net/http/http_cache_**transaction.h
>  net/http/http_net_log_params.h
>  M net/http/http_network_layer.h
>  M net/http/http_network_**transaction.h
>  net/http/http_proxy_client_**socket.h
>  M net/http/http_proxy_client_**socket_pool.h
>  M net/http/http_stream_factory_**impl.h
>  M net/http/http_stream_factory_**impl_request.h
>  M net/http/http_stream_parser.h
>  M net/http/http_transaction_**unittest.h
>  M net/http/mock_allow_url_**security_manager.h
>  M net/http/mock_gssapi_library_**posix.h
>  M net/http/url_security_manager.**h
>  M net/server/http_server.h
>  M net/socket/client_socket_pool_**base.h
>  M net/socket/client_socket_pool_**manager.h
>  M net/socket/socket_test_util.h
>  M net/socket/socks5_client_**socket.h
>  M net/socket/socks_client_**socket.h
>  M net/socket/socks_client_**socket_pool.h
>  M net/socket/ssl_client_socket_**mac.h
>  M net/socket/ssl_client_socket_**nss.h
>  M net/socket/ssl_client_socket_**pool.h
>  M net/socket/ssl_error_params.h
>  M net/socket/ssl_server_socket_**nss.h
>  M net/socket/tcp_client_socket_**libevent.h
>  M net/socket/tcp_server_socket_**libevent.h
>  net/socket/transport_client_**socket_pool.h
>  M net/spdy/spdy_http_stream.h
>  M net/spdy/spdy_proxy_client_**socket.h
>  M net/spdy/spdy_session.h
>  M net/spdy/spdy_session_pool.h
>  M net/spdy/spdy_stream.h
>  M net/spdy/spdy_websocket_**stream.h
>  net/tools/fetch/http_listen_**socket.h
>  M net/tools/fetch/http_session.h
>  M net/udp/udp_socket_libevent.h
>  net/url_request/url_request_**about_job.h
>  M net/url_request/url_request_**data_job.h
>  M net/url_request/url_request_**error_job.h
>  M net/url_request/url_request_**file_dir_job.h
>  M net/url_request/url_request_**file_job.h
>  M net/url_request/url_request_**ftp_job.h
>  M net/url_request/url_request_**http_job.h
>  net/url_request/url_request_**job.h
>  M net/url_request/url_request_**netlog_params.h
>  M net/url_request/url_request_**redirect_job.h
>  M net/url_request/url_request_**simple_job.h
>  M net/url_request/url_request_**test_job.h
>  M net/url_request/url_request_**throttler_entry.h
>  M net/url_request/url_request_**throttler_header_adapter.h
>  M net/websockets/websocket_job.h
>  net/websockets/websocket_net_**log_params.h
>
>
>

[commit-bot: I haz the power, 2011-11-15 21:54:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/8568021/2001

[commit-bot: I haz the power, 2011-11-15 21:54:51]

Can't process patch for file net/websockets/websocket_net_log_params.h.
File's status is None, patchset upload is incomplete.

[cbentzel, 2011-11-16 10:37:28]

Drive-by LGTM

Awesome. Did you find these with a script, or have to manually  discover them?

[Avi (use Gerrit), 2011-11-16 13:52:54]

On 2011/11/16 10:37:28, cbentzel wrote:
> Awesome. Did you find these with a script, or have to manually  discover them?

I added support to our Clang style plugin. Once I fix all of this, I'll commit
the plugin change and enforce it that way.

(Not sure how you'd convince a script to be able to say, "if this function
overrides, but isn't tagged, and doesn't override a function from a class that's
in the WebKit namespace".)