Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 8568020: chromeos: Explicitly initialize and shut down UpgradeDetectorChromeos. (Closed)

Created:
9 years, 1 month ago by satorux1
Modified:
9 years, 1 month ago
Reviewers:
stevenjb, Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Explicitly initialize and shut down UpgradeDetectorChromeos. The motivation is to solve a dependency issue between UpgradeDetectorChromeos and DBusThreadManager, that'll replace CrosLibrary (i.e. UpgradeDetectorChromeos will be using DBusThreadManager internally). BUG=16564 TEST=Upgrade detector works as before. (create a new image, start dev server, and run update_engine_client --update, and confirm that an arrow is shown on the wrench menu icon, once the update is downloaded in the background). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110409

Patch Set 1 #

Patch Set 2 : fix UpdateScreenTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/update_screen_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/upgrade_detector_chromeos.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/upgrade_detector_chromeos.cc View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
satorux1
9 years, 1 month ago (2011-11-15 20:54:15 UTC) #1
satorux1
9 years, 1 month ago (2011-11-15 20:57:02 UTC) #2
stevenjb
lgtm
9 years, 1 month ago (2011-11-16 01:04:40 UTC) #3
satorux1
+Nikita for a minor change in 'login'. The expectation is slightly changed as the first ...
9 years, 1 month ago (2011-11-16 07:10:05 UTC) #4
satorux1
LGTM. Please include chrome/browser/chromeos/system/runtime_environment.h from files where IsRunningOnChromeOS() is used.
9 years, 1 month ago (2011-11-17 00:32:08 UTC) #5
satorux1
Oops, I replied to a wrong code review issue...
9 years, 1 month ago (2011-11-17 00:38:31 UTC) #6
satorux1
9 years, 1 month ago (2011-11-17 02:50:00 UTC) #7
Hmm, I was able to commit the patch by "git cl dcommit" without any warnings
despite the fact that I didn't get LGTM from
chrome/browser/chromeos/login/OWNERS. This may be a bug in the presubmit system?

Powered by Google App Engine
This is Rietveld 408576698