Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1600)

Side by Side Diff: chrome/browser/prefs/pref_service.cc

Issue 8568019: Introduce per-tab preferences service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed ProfileSyncServicePreferenceTest tests Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/pref_service.h" 5 #include "chrome/browser/prefs/pref_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/file_path.h" 12 #include "base/file_path.h"
13 #include "base/file_util.h" 13 #include "base/file_util.h"
14 #include "base/logging.h" 14 #include "base/logging.h"
15 #include "base/message_loop.h" 15 #include "base/message_loop.h"
16 #include "base/metrics/histogram.h" 16 #include "base/metrics/histogram.h"
17 #include "base/stl_util.h" 17 #include "base/stl_util.h"
18 #include "base/string_number_conversions.h" 18 #include "base/string_number_conversions.h"
19 #include "base/string_util.h" 19 #include "base/string_util.h"
20 #include "base/value_conversions.h" 20 #include "base/value_conversions.h"
21 #include "build/build_config.h" 21 #include "build/build_config.h"
22 #include "chrome/browser/browser_process.h" 22 #include "chrome/browser/browser_process.h"
23 #include "chrome/browser/extensions/extension_pref_store.h" 23 #include "chrome/browser/extensions/extension_pref_store.h"
24 #include "chrome/browser/policy/configuration_policy_pref_store.h" 24 #include "chrome/browser/policy/configuration_policy_pref_store.h"
25 #include "chrome/browser/prefs/command_line_pref_store.h" 25 #include "chrome/browser/prefs/command_line_pref_store.h"
26 #include "chrome/browser/prefs/default_pref_store.h" 26 #include "chrome/browser/prefs/default_pref_store.h"
27 #include "chrome/browser/prefs/incognito_user_pref_store.h" 27 #include "chrome/browser/prefs/incognito_user_pref_store.h"
28 #include "chrome/browser/prefs/per_tab_user_pref_store.h"
28 #include "chrome/browser/prefs/pref_model_associator.h" 29 #include "chrome/browser/prefs/pref_model_associator.h"
29 #include "chrome/browser/prefs/pref_notifier_impl.h" 30 #include "chrome/browser/prefs/pref_notifier_impl.h"
30 #include "chrome/browser/prefs/pref_value_store.h" 31 #include "chrome/browser/prefs/pref_value_store.h"
31 #include "chrome/browser/ui/profile_error_dialog.h" 32 #include "chrome/browser/ui/profile_error_dialog.h"
32 #include "chrome/common/json_pref_store.h" 33 #include "chrome/common/json_pref_store.h"
33 #include "content/public/browser/browser_thread.h" 34 #include "content/public/browser/browser_thread.h"
34 #include "grit/chromium_strings.h" 35 #include "grit/chromium_strings.h"
35 #include "grit/generated_resources.h" 36 #include "grit/generated_resources.h"
36 #include "ui/base/l10n/l10n_util.h" 37 #include "ui/base/l10n/l10n_util.h"
37 38
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 ConfigurationPolicyPrefStore* recommended_cloud = NULL; 148 ConfigurationPolicyPrefStore* recommended_cloud = NULL;
148 #endif // ENABLE_CONFIGURATION_POLICY 149 #endif // ENABLE_CONFIGURATION_POLICY
149 150
150 CommandLinePrefStore* command_line = 151 CommandLinePrefStore* command_line =
151 new CommandLinePrefStore(CommandLine::ForCurrentProcess()); 152 new CommandLinePrefStore(CommandLine::ForCurrentProcess());
152 JsonPrefStore* user = new JsonPrefStore( 153 JsonPrefStore* user = new JsonPrefStore(
153 pref_filename, 154 pref_filename,
154 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)); 155 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
155 DefaultPrefStore* default_pref_store = new DefaultPrefStore(); 156 DefaultPrefStore* default_pref_store = new DefaultPrefStore();
156 157
158 PrefNotifierImpl* pref_notifier = new PrefNotifierImpl();
159 PrefModelAssociator* pref_sync_associator = new PrefModelAssociator();
160
157 return new PrefService( 161 return new PrefService(
158 managed_platform, managed_cloud, extension_prefs, 162 pref_notifier,
159 command_line, user, recommended_platform, 163 new PrefValueStore(
160 recommended_cloud, default_pref_store, async); 164 managed_platform,
165 managed_cloud,
166 extension_prefs,
167 command_line,
168 user,
169 recommended_platform,
170 recommended_cloud,
171 default_pref_store,
172 pref_sync_associator,
173 pref_notifier),
174 user,
175 default_pref_store,
176 pref_sync_associator,
177 async);
161 } 178 }
162 179
163 PrefService* PrefService::CreateIncognitoPrefService( 180 PrefService* PrefService::CreateIncognitoPrefService(
164 PrefStore* incognito_extension_prefs) { 181 PrefStore* incognito_extension_prefs) {
165 return new PrefService(*this, incognito_extension_prefs); 182 PrefNotifierImpl* pref_notifier = new PrefNotifierImpl();
183 PersistentPrefStore* incognito_pref_store =
184 new IncognitoUserPrefStore(user_pref_store_.get());
185 return new PrefService(
186 pref_notifier,
187 pref_value_store_->CloneAndSpecialize(
188 NULL, // managed_platform_prefs
189 NULL, // managed_cloud_prefs
190 incognito_extension_prefs,
191 NULL, // command_line_prefs
192 incognito_pref_store,
193 NULL, // recommended_platform_prefs
194 NULL, // recommended_cloud_prefs
195 default_store_.get(),
196 NULL, // pref_sync_associator
197 pref_notifier),
198 incognito_pref_store,
199 default_store_.get(),
200 NULL,
201 false);
166 } 202 }
167 203
168 PrefService::PrefService(PrefStore* managed_platform_prefs, 204 PrefService* PrefService::CreatePrefServiceWithPerTabPrefStore() {
169 PrefStore* managed_cloud_prefs, 205 PrefNotifierImpl* pref_notifier = new PrefNotifierImpl();
170 PrefStore* extension_prefs, 206 PersistentPrefStore* per_tab_pref_store =
171 PrefStore* command_line_prefs, 207 new PerTabUserPrefStore(user_pref_store_.get());
172 PersistentPrefStore* user_prefs, 208 DefaultPrefStore* default_store = new DefaultPrefStore();
173 PrefStore* recommended_platform_prefs, 209 return new PrefService(
174 PrefStore* recommended_cloud_prefs, 210 pref_notifier,
175 DefaultPrefStore* default_store, 211 pref_value_store_->CloneAndSpecialize(
176 bool async) 212 NULL, // managed_platform_prefs
177 : user_pref_store_(user_prefs), 213 NULL, // managed_cloud_prefs
178 default_store_(default_store) { 214 NULL, // extension_prefs
179 pref_sync_associator_.reset(new PrefModelAssociator(this)); 215 NULL, // command_line_prefs
180 pref_notifier_.reset(new PrefNotifierImpl(this)); 216 per_tab_pref_store,
181 pref_value_store_.reset( 217 NULL, // recommended_platform_prefs
182 new PrefValueStore(managed_platform_prefs, 218 NULL, // recommended_cloud_prefs
183 managed_cloud_prefs, 219 default_store,
184 extension_prefs, 220 NULL,
185 command_line_prefs, 221 pref_notifier),
186 user_pref_store_, 222 per_tab_pref_store,
187 recommended_platform_prefs, 223 default_store,
188 recommended_cloud_prefs, 224 NULL,
189 default_store, 225 false);
190 pref_sync_associator_.get(),
191 pref_notifier_.get()));
192 InitFromStorage(async);
193 } 226 }
194 227
195 PrefService::PrefService(const PrefService& original, 228 PrefService::PrefService(PrefNotifierImpl* pref_notifier,
196 PrefStore* incognito_extension_prefs) 229 PrefValueStore* pref_value_store,
197 : user_pref_store_( 230 PersistentPrefStore* user_prefs,
198 new IncognitoUserPrefStore(original.user_pref_store_.get())), 231 DefaultPrefStore* default_store,
199 default_store_(original.default_store_.get()) { 232 PrefModelAssociator* pref_sync_associator,
200 // Incognito mode doesn't sync, so no need to create PrefModelAssociator. 233 bool async)
201 pref_notifier_.reset(new PrefNotifierImpl(this)); 234 : pref_notifier_(pref_notifier),
202 pref_value_store_.reset(original.pref_value_store_->CloneAndSpecialize( 235 pref_value_store_(pref_value_store),
203 NULL, // managed_platform_prefs 236 user_pref_store_(user_prefs),
204 NULL, // managed_cloud_prefs 237 default_store_(default_store),
205 incognito_extension_prefs, 238 pref_sync_associator_(pref_sync_associator) {
206 NULL, // command_line_prefs 239 pref_notifier_->SetPrefService(this);
207 user_pref_store_.get(), 240 if (pref_sync_associator_.get())
208 NULL, // recommended_platform_prefs 241 pref_sync_associator_->SetPrefService(this);
209 NULL, // recommended_cloud_prefs 242 InitFromStorage(async);
210 default_store_.get(),
211 NULL, // pref_sync_associator_
212 pref_notifier_.get()));
213 } 243 }
214 244
215 PrefService::~PrefService() { 245 PrefService::~PrefService() {
216 DCHECK(CalledOnValidThread()); 246 DCHECK(CalledOnValidThread());
217 STLDeleteContainerPointers(prefs_.begin(), prefs_.end()); 247 STLDeleteContainerPointers(prefs_.begin(), prefs_.end());
218 prefs_.clear(); 248 prefs_.clear();
219 249
220 // Reset pointers so accesses after destruction reliably crash. 250 // Reset pointers so accesses after destruction reliably crash.
221 pref_value_store_.reset(); 251 pref_value_store_.reset();
222 user_pref_store_ = NULL; 252 user_pref_store_ = NULL;
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 return pref_value_store()->PrefValueFromDefaultStore(name_.c_str()); 927 return pref_value_store()->PrefValueFromDefaultStore(name_.c_str());
898 } 928 }
899 929
900 bool PrefService::Preference::IsUserModifiable() const { 930 bool PrefService::Preference::IsUserModifiable() const {
901 return pref_value_store()->PrefValueUserModifiable(name_.c_str()); 931 return pref_value_store()->PrefValueUserModifiable(name_.c_str());
902 } 932 }
903 933
904 bool PrefService::Preference::IsExtensionModifiable() const { 934 bool PrefService::Preference::IsExtensionModifiable() const {
905 return pref_value_store()->PrefValueExtensionModifiable(name_.c_str()); 935 return pref_value_store()->PrefValueExtensionModifiable(name_.c_str());
906 } 936 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698